easye authored Oct 29, 2012 and Luís Oliveira committed Nov 04, 2012

The "-fPIC" flag will always be necessary when using GCC-derived compilers as I understand it.

Additionally, Solaris compilation options now unconditionally tries a
64bit build.  Contemporary Solaris (since Solaris 10), are hybrid
32/64 bit environments where "uname -m" reports "i86pc".  Whether one
wants the 32 or 64 bit version of the libraries depends on the type of
the Lisp implementation doing the loading, which is currently not
available in the environment in which make(1) is executing.

Fix an error in the recursive call in libffi-type-pointer for
foreign-struct-type, now parse the slot-type, which is unparsed.  This
makes FSBV.3 and FSBV.4 succeed.  Removed quote from test FSBV.2; this
makes FSBV.2 succeed.

* Instead of a special variable, the parsed struct type instance is now
  annotated to let the type system know whether we're dealing with
  deprecated semantics (struct type canonicalizes to :pointer) or not.

  This approach should hopefully be much less error-prone.

* Disabled translations for bare structs.

* Fixed and commented out some bogus tests.

DEFCFUN.UNSIGNED-LONG-LONG fails on Allegro: lp#914500.

Fixes lp#911557. Reported by Elias Pipping. Solution courtesy of
Daniel Herring.

Added test struct-values.translation.mem-aref.1 that creates an array
of two struct-pairs, sets their values, then retrieves both pairs.
This test fails: the returned first pair is actually the second, and
the returned second pair is garbage.  Repeating the same test gives
different garbage.

(with-foreign-object (p '(:struct struct-pair) 2)
      (setf (mem-aref p '(:struct struct-pair) 0) '(1 . 2)
            (mem-aref p '(:struct struct-pair) 1) '(3 . 4))
      (values (mem-aref p '(:struct struct-pair) 0)
              (mem-aref p '(:struct struct-pair) 1)))
(3 . 4)
(213829 . 0)

(with-foreign-object (p '(:struct struct-pair) 2)
      (setf (mem-aref p '(:struct struct-pair) 0) '(1 . 2)
            (mem-aref p '(:struct struct-pair) 1) '(3 . 4))
      (values (mem-aref p '(:struct struct-pair) 0)
              (mem-aref p '(:struct struct-pair) 1)))
(3 . 4)
(425347 . 0)

Add definition of C functions prodsumpair and doublepairdouble that
take, and for the latter, return, the structure struct-pair+double
(struct_pair_double) that has a structure struct-pair (struct_pair) in
its slot 'pr.  Two tests, fsbv.3 and fsbv.4, have been defined, and
pass.  Fixed argument to libffi-type-pointer call in
libffi-type-pointer :around method so that these will work.

Add struct-pair+double recursive structure translation test, which
passes when run individually in SBCL.

Tests fsbv.1 and fsbv.2 added that test foreign structure call and
return by value.  This includes the C file and addition to makefile to
generate the appropriate library, libfsbv.  So that the tests are
properly defined, load cffi-fsbv and then cffi-tests.  Both tests
should pass.  The test returning a structure, fsbv.2, exposed an error
in the form generated by ffcall-body-libffi; because it always
generated a mem-aref on the return value, the subsequent
translate-from-foreign was effectively making a double translation.
Thus, this form generation has been conditionalized so that if
translate-from-foreign will not be applied (e.g., built-in-type) to
call mem-aref, otherwise just return the pointer.

Define a structure struct-pair-default-translate and test
struct-values-default.translation.mem-ref.1 to test translation from
foreign structure to plist.  In order to make this work, rewrite
mem-ref function to parallel exactly the mem-ref compiler macro,
because conditionals were not correct.

Add :argument-precedence-order to defgenerics
translate-into-foreign-memory and translate-to-foreign, and removed
the 'cons specializer in the tests.

Otherwise the default plist-handling method kicks in.

Add respective struct tests, one of which fails. Also, missing union
tests.

Update STRUCT-VALUES.* tests.

Said expansion breaks the protocol between TRANSLATE-TO-FOREIGN and
FREE-TRANSLATED-OBJECT.

This wasn't an issue when using EXPAND-TO-FOREIGN-DYN since it discards
the default expansion of EXPAND-TO-FOREIGN. Only CONVERT-OBJECT-FOREIGN
and DEFCALLBACK call EXPAND-TO-FOREIGN directly and the latter has to
discard the second value anyway.

All fail but STRUCT-VALUES.TRANSLATION.1.

As of OSX 10.6.6, loading things like CoreFoundation on something
other than the initial thread results in a crash.

Implemented workaround on SBCL based on what CCL does upstream. Other
Lisps might benefit from similar workarounds.

Patch courtesy of Greg Pfeil. Closes lp:622272.

- Added tests: FOREIGN-GLOBALS.UNDEFINED.1 and FOREIGN-GLOBALS.ERROR.1.
- Check that FOREIGN-SYMBOL-POINTER's 'name' arg is a string.

Add tests too

Patch courtesy of Dorian Taylor, lp#631972.

Patch courtesy of Juan Jose Garcia-Ripoll.