Skip to content
Commit 1b88e331 authored by Liam M. Healy's avatar Liam M. Healy
Browse files

Restore default type class name

In defcstruct, there was a line, removed in be626770, that set a
default type class name by appending "-TCLASS".  Without this line,
the class will be directly FOREIGN-STRUCT-TYPE instead of a subclass.
This is acceptable if the translate methods are not going to be
redefined, but if they are, any change will apply to all instances
(including instances of subclasses of other structures, which may call
these with call-next-method).  In fact, there is a check in
define-translation-method to prevent redefinition with that macro, but
of course a defmethod would be just as bad.

While in principal one can specify the :class argument, this isn't
always possible, for example, if the structure was made by groveling.
Even so, it is a bad idea to make a default which has the potential
for this kind of harm.

This fix now permits GSLL to compile and load correctly.
parent 588b96ff
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment