Skip to content
  1. May 29, 2013
  2. Apr 06, 2013
  3. Jan 03, 2013
  4. Nov 07, 2012
  5. Sep 18, 2012
    • Scott McKay's avatar
      Speed up unoptimized serialization · 9a1d9899
      Scott McKay authored
      Testing : precheckin --full --strict-errors
      Reviewer: Fare
      
      JTB impact: No
      Ops impact: No
      
      Change to config                        : No
      Change to XML schema                    : No
      Change to DB schema                     : No
      Change to transport (timeouts, headers) : No
      Any change (or new use) of OAQs         : No
      Change to inter-component transactions  : No
      Depends on any other checkin / bug      : No
      
      Tests that will verify:
      
      The CL-Protobufs tests
      
      Description:
      
      The unoptimized serialization code was slower than
      it needed to be and was a Niagara falls of consing.
      
      The problem is that (map () (curry ...)) is poorly
      optimized, which is a shame because it's such a nice
      coding style. :-P
      
      The fix is to replace 'map' with iteration (sigh) in
      a few critical places.
      
      - Add 'doseq', which chooses between 'dolist' or 'dovector'.
      - Make 'serialize-object', 'deserialize-object' and 'object-size'
        use 'doseq' instead of using 'map'.
      - Ditto for 'print-text-format'.
      - Fix the 'serialize-packed' and 'packed-size' optimizers to
        use 'dolist' or 'dovector' based on whether the field is
        a vector field. This makes the optimized code faster, too.
      - Make the optimized serializer generators pass in 'vectorp'
        so that the wire-format optimizers can do a better job.
      
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/libs/cl-protobufs@562921 f8382938-511b-0410-9cdd-bb47b084005c
      9a1d9899
  6. Jun 11, 2012
  7. Jun 05, 2012
  8. Jun 01, 2012
  9. May 25, 2012
    • Scott McKay's avatar
      Fix a few more things discovered by the tests: · 67fc7299
      Scott McKay authored
       - 'reinitialize-slot' didn't quite work.
       - Add a geodata example that uses vectors for repeated fields,
         which uncovered a bug in the optimized deserializers.
       - Importing the geodata CLOS classes revealed a bug in default
         handling when the default is provided only in 'defclass'.
       - Fix the knock-on bug in deserialization and the optimized
         (de)serialization caused the above.
       - Add tighter types in 'decode-uint32' and 'decode-uint64'.
      
      Passes 'precheckin'. Even with the new unit tests in place.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@545865 f8382938-511b-0410-9cdd-bb47b084005c
      67fc7299
  10. May 23, 2012
  11. May 18, 2012
    • Scott McKay's avatar
      Now that Protobufs has a test suite, it found a few things to fix. · 0d1611ab
      Scott McKay authored
       - Don't generate warnings for anonymous enums, they're harmless
         and ubiquitous.
       - 'member' types where are all the members are keywords, is a symbol,
         which got converted to a Protobufs 'string'. Wrong.
       - If a field has an enum type, the (Lisp) default value should be
         treated as a keyword.
       - When parsing a .proto file or using the 'define-xxx' macros, any
         options that are handled specially should be trimmed from the
         options list so that they don't get printed twice.
       - Add 'remove-options' for the above.
       - Make the options printer be more type-aware.
       - Clean up examples.lisp
       - 'schemas-equal' can ignore the schema name/class if they're null.
      
      Passes 'precheckin'. Even with the new unit tests in place.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544737 f8382938-511b-0410-9cdd-bb47b084005c
      0d1611ab
  12. May 16, 2012
    • Scott McKay's avatar
      At Sergey's request, make some of the names better: · a31c828e
      Scott McKay authored
       - 'define-proto' -> 'define-schema'
       - 'protobuf' (class name) -> 'protobuf-schema'
       - 'find-protobuf' -> 'find-schema'
       - 'parse-protobuf-from-file' -> 'parse-schema-from-file'
       - 'parse-protobuf-from-stream' -> 'parse-schema-from-file'
       - 'write-protobuf' -> 'write-schema'
       - 'write-protobuf-as' -> 'write-schema-as'
       - 'ensure-all-protobufs' -> 'ensure-all-protobufs'
       - 'ensure-protobuf' -> 'ensure-protobuf'
       - 'protobuf-upgradable' -> 'schema-upgradable'
       - 'protobufs-equal' -> 'schemas-equal'
       - 'generate-protobuf-schema-for-classes' -> 'generate-schema-for-classes'
       - 'write-protobuf-schema-for-classes' -> 'write-schema-for-classes'
      
      Update the Quake Protobufs schema generator to use the new names.
      
      The Protobufs documentation doesn't say so, but enums can be packed.
       - Update the wire-level protocol to (de)serialize packed enums.
       - Update the serialization code to use the new wire functions.
      
      Passes 'precheckin'.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544299 f8382938-511b-0410-9cdd-bb47b084005c
      a31c828e
    • Scott McKay's avatar
      Tie up a few loose ends with 'unittests.proto'; there are still a few · a13fca91
      Scott McKay authored
      edge case problems, but it's good enough to continue the Stubby work.
      The critical .proto files (descriptor.proto, etc) all appear to work.
      
      More precise mapping of (mainly integer) types from .lisp to .proto files
      so that we can a truly exact model once we compile the .lisp file. It may
      not make any difference, but better safe than sorry.
       - Introduce Lisp type 'int32', 'int64', 'uint32', etc
       - Make Lisp->Protobufs recognize the new Lisp types
       - Make Protobufs schema printers recognize the new types
      
      Fix up the handling of imports and namespaces.
       - Always use truenames to record schemas
       - Fix typo in 'find-enum' that caused it never to search other schemas
       - Record the schema in *all-protobufs* at exactly the right time,
         and simplify 'make-load-form' methods
      
      A few tweaks to (de)serialization.
       - Make the bodies for empty messages not generate compiler warnings
       - Don't make ':packed t' be the default, the user has to say so
       - The user documentation doesn't say so, but booleans can be packed.
      
      Passes 'precheckin'.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544222 f8382938-511b-0410-9cdd-bb47b084005c
      a13fca91
  13. May 11, 2012
  14. May 10, 2012
  15. May 09, 2012
  16. May 08, 2012
  17. May 07, 2012
  18. May 04, 2012
  19. May 02, 2012
  20. Apr 25, 2012
  21. Apr 23, 2012
  22. Apr 19, 2012
  23. Apr 02, 2012
  24. Apr 01, 2012
  25. Mar 29, 2012
  26. Mar 27, 2012
  27. Mar 26, 2012