Skip to content
  1. Sep 12, 2012
    • Scott McKay's avatar
      Fix some user-reported bugs · 5dc5d8d1
      Scott McKay authored 
      Testing : precheckin --full --strict-errors
Reviewer: Sergey V, Shaun M

JTB impact: No
Ops impact: No

Change to config                        : No
Change to XML schema                    : No
Change to DB schema                     : No
Change to transport (timeouts, headers) : No
Any change (or new use) of OAQs         : No
Change to inter-component transactions  : No
Depends on any other checkin / bug      : No

Tests that will verify:

The CL-Protobufs tests

Description:

I had made a "policy decision" that the package created
by importing a .proto file would (:use :common-lisp). In
practice, this turned out to be a mistake. Sergey suggested
a fix that I think is correct, so in it goes.

Shaun noticed that the optimized 'serialize-object' and
'object-size' methods didn't quite implement what they were
supposed to for optional boolean fields whose value was never
supplied. Fix the optimized methods to implement the same
(correct) semantics as the unoptimized ones.



git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/libs/cl-protobufs@561714 f8382938-511b-0410-9cdd-bb47b084005c
      5dc5d8d1
  3. Sep 07, 2012
    • Scott McKay's avatar
      Add a few missing features that aren't in any documentation. · 5d4236e6
      Scott McKay authored 
      Testing : precheckin --full --strict-errors
Reviewer: Fare (please)

JTB impact: No
Ops impact: No

Change to config                        : No
Change to XML schema                    : No
Change to DB schema                     : No
Change to transport (timeouts, headers) : No
Any change (or new use) of OAQs         : No
Change to inter-component transactions  : No
Depends on any other checkin / bug      : No

Tests that will verify:

I extended the CL-Protobufs examples

Description:

Add a few missing features that aren't in any documentation.

String literals can look like "foo"<whitespace>"bar".
 - Fix 'parse-string' to handle this.

Option values can be complex structures, not just atoms.
 - If 'parse-proto-option' sees a '{' character after the '=',
   it should use 'parse-text-format' to read the option value.
 - Fix the 'protobuf-option' printer to call 'print-text-format'
   for complex option values.
 - Minor refactoring to the text format parser and printer in
   order to support the above.



git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/libs/cl-protobufs@560639 f8382938-511b-0410-9cdd-bb47b084005c
      5d4236e6
  5. Sep 04, 2012
    • Scott McKay's avatar
      Add stub support for streaming RPC APIs. · 5293ada2
      Scott McKay authored 
      Testing : precheckin --full --strict-errors
Reviewer: Fare (please)

JTB impact: No
Ops impact: No

Change to config                        : No
Change to XML schema                    : No
Change to DB schema                     : No
Change to transport (timeouts, headers) : No
Any change (or new use) of OAQs         : No
Change to inter-component transactions  : No
Depends on any other checkin / bug      : No

Tests that will verify:

I extended the CL-Protobufs tests

Description:

Add support for a 'streams' type in Protobufs RPC methods.
 - Add a few slots to 'protobufs-method'
 - Add '&key streams' to the method arglists in 'define-service'
 - Extend the parser to handle "streams" in addition to the
   'streams_type' option
 - Extend the printer
 - Change a test to use a 'streams' type
 - While we're in the neighborhood, allow an optional '=>'
   between the input and output methods in 'define-service';
   it makes it a bit more readable
 - Update the documentation



git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/libs/cl-protobufs@560147 f8382938-511b-0410-9cdd-bb47b084005c
      5293ada2
  7. Aug 28, 2012
  9. Aug 27, 2012
  11. Aug 24, 2012
  13. Jun 28, 2012
  15. Jun 27, 2012
  17. Jun 26, 2012
  19. Jun 18, 2012
  21. Jun 14, 2012
  23. Jun 13, 2012
  25. Jun 11, 2012
  27. Jun 05, 2012
  29. Jun 01, 2012
  31. May 30, 2012
  33. May 25, 2012
  35. May 23, 2012
  37. May 22, 2012
    • Scott McKay's avatar
      Add more stuff to the test suite, and fix what it uncovered. · b6317f29
      Scott McKay authored 
       - Behavior of ':default xxx'/[default=xxx] was not stable,
   so add an "empty default" marker and respect it during
   parsing and printing.
 - 'find-option' now returns a third "found-p" value, useful
   for the better handling of defaults.
 - Don't print slot readers/writers if they have the same name
   as what would be (silently) generated by the macrology.
 - Don't print 'import descriptor.proto' lines if there are
   no 'lisp_xxx' options in the generated code.
 - Add 'clear-field' to the API; add the functions it needs.
 - Be more careful about how :conc-name interacts with the
   generation of readers/writers.
 - When parsing from a .proto file, force the conc-name to
   be "" unless requested explicitly not to. This has the
   effect of generating readers/writers for all the fields
   of imported Protobufs messages, which I think is probably
   the desired behavior.
 - Add 'make-byte-vector' for convenience.

Passes 'precheckin'. Even with the new unit tests in place.


git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@545177 f8382938-511b-0410-9cdd-bb47b084005c
      b6317f29
  39. May 18, 2012
    • Scott McKay's avatar
      Now that Protobufs has a test suite, it found a few things to fix. · 0d1611ab
      Scott McKay authored 
       - Don't generate warnings for anonymous enums, they're harmless
   and ubiquitous.
 - 'member' types where are all the members are keywords, is a symbol,
   which got converted to a Protobufs 'string'. Wrong.
 - If a field has an enum type, the (Lisp) default value should be
   treated as a keyword.
 - When parsing a .proto file or using the 'define-xxx' macros, any
   options that are handled specially should be trimmed from the
   options list so that they don't get printed twice.
 - Add 'remove-options' for the above.
 - Make the options printer be more type-aware.
 - Clean up examples.lisp
 - 'schemas-equal' can ignore the schema name/class if they're null.

Passes 'precheckin'. Even with the new unit tests in place.


git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544737 f8382938-511b-0410-9cdd-bb47b084005c
      0d1611ab
  41. May 16, 2012
    • Scott McKay's avatar
      At Sergey's request, make some of the names better: · a31c828e
      Scott McKay authored 
       - 'define-proto' -> 'define-schema'
 - 'protobuf' (class name) -> 'protobuf-schema'
 - 'find-protobuf' -> 'find-schema'
 - 'parse-protobuf-from-file' -> 'parse-schema-from-file'
 - 'parse-protobuf-from-stream' -> 'parse-schema-from-file'
 - 'write-protobuf' -> 'write-schema'
 - 'write-protobuf-as' -> 'write-schema-as'
 - 'ensure-all-protobufs' -> 'ensure-all-protobufs'
 - 'ensure-protobuf' -> 'ensure-protobuf'
 - 'protobuf-upgradable' -> 'schema-upgradable'
 - 'protobufs-equal' -> 'schemas-equal'
 - 'generate-protobuf-schema-for-classes' -> 'generate-schema-for-classes'
 - 'write-protobuf-schema-for-classes' -> 'write-schema-for-classes'

Update the Quake Protobufs schema generator to use the new names.

The Protobufs documentation doesn't say so, but enums can be packed.
 - Update the wire-level protocol to (de)serialize packed enums.
 - Update the serialization code to use the new wire functions.

Passes 'precheckin'.


git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544299 f8382938-511b-0410-9cdd-bb47b084005c
      a31c828e
  43. May 14, 2012
    • Scott McKay's avatar
      A few more model fixes to fully support google/protobuf/unittest.proto · 4157162a
      Scott McKay authored 
      (I love this file, it's got one of everything.)

 - The printer should not print extended fields in any message
   that further extends an extended message.
 - If parsing or importing a .proto file needs a Lisp package that
   does not exist, go ahead and create it.
 - Importing now tracks all the schemas imported by the "parent",
   this so that we can search namespaces thoroughly.
 - It looks like 'define-extend' can accept groups. For a deprecated
   feature, it sure is a pain in the neck.
 - Make 'find-message' and 'find-enum' search all namespaces.
 - Print escaped strings, just for completeness.
 - Annotate a couple of common options with their types.

Passes 'precheckin'. Passes my by-hand tests and is epsilon away from
handling the worst .proto file around.


git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@543912 f8382938-511b-0410-9cdd-bb47b084005c
      4157162a
  45. May 13, 2012
    • Scott McKay's avatar
      Get google/protobuf/unittest.proto working, insofar as it parses · 3d3775ce
      Scott McKay authored 
      completely and produces what appears to be a correct model. Next
up, ensure (de)serialization works with this complex beast, which
sets the stage for running the (very complete) Google tests.

 - Be much more careful to preserve type information in option
   values and field defaults, both in the macros and the parser.
   Make the slots in their model objects be untyped.
 - This makes it easier for the Proto and Lisp printers to produce
   exactly the right output, so fix them, too. Be extra careful
   with booleans.
 - Fix the printer to recognize more of the standard options so
   that their values get printed with the correct type.
 - Learn to parse more complicated numeric and integer constants.
 - Learn to parse escaped strings.
 - Learn to parse comma-separated options.
 - Learn to parse extensions with no 'to' specifier.
 - Fix the places that used (deprecated) :single instead of :float.
 - Proto enum values always map to Lisp keywords, so don't futz
   with packages for them.
 - Add some more doc strings.
 - Add some more examples-that-will-become-tests.

Passes 'precheckin'. Passes my by-hand tests.


git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@543727 f8382938-511b-0410-9cdd-bb47b084005c
      3d3775ce
  47. May 10, 2012
  49. May 09, 2012
  51. May 08, 2012
  53. May 04, 2012
  55. Apr 25, 2012
  57. Apr 24, 2012
  59. Apr 19, 2012
  61. Apr 18, 2012
  63. Apr 13, 2012
  65. Apr 12, 2012