Skip to content
  1. Apr 02, 2013
  2. Apr 01, 2013
  3. Mar 20, 2013
  4. Mar 08, 2013
  5. Mar 07, 2013
  6. Mar 06, 2013
    • Alejandro R Sedeño's avatar
      asdf-support: rework import again · c7d626fa
      Alejandro R Sedeño authored
      * DO-PROCESS-IMPORT is now responsible for deciding whether or not to
        process an import. It does so by searching for the .proto to be
        imported, and upon finding it, checks to see if we alredy have a
        schema for that pathname. Additionally, it now returns the pathname.
      
      * PROCESS-IMPORTS and PROCESS-IMPORTS-FROM-FILE now defer the work of
        figuring out whether or not an import has been done to
        DO-PROCESS-IMPORT. PROCESS-IMPORTS uses the return value of
        DO-PROCESS-IMPORT to update the PROTO-IMPORTED-SCHEMAS of the schema
        being processed.
      c7d626fa
    • Alejandro R Sedeño's avatar
      asdf-support: more filename mangling · 309d03e9
      Alejandro R Sedeño authored
      New functions:
      
      * ASDF::PROTOBUF-MANGLE-NAME: Takes a pathname, returns a string to be
        used as a filename that represents the original path.
        e.g., #P"/foo/bar/baz.quux" becomes "foo-bar-baz-quux"
      
      * ASDF::PROTOBUF-LISPIZE-PATHNAME: Takes a pathname, returns a new
        pathname with the name mangled as described above, and with a lisp
        type.
      309d03e9
  7. Mar 03, 2013
    • Scott McKay's avatar
      In the spirit of making CL-Protobufs represent exemplary modern Common Lisp code: · 7ed71234
      Scott McKay authored
       - Use 'defparameter' instead of 'defvar' where appropriate.
       - Fix 'defvar' doc strings to distinguish between globals and "thread locals".
       - Avoid using 'nconc'. introduce a new 'appendf' macro instead.
       - Add a comment lamenting the fact that exporting something like 'proto-options'
         also exports the writer '(setf proto-options)'. Fixed in Dylan.
      7ed71234
  8. Feb 28, 2013
  9. Feb 27, 2013
  10. Dec 06, 2012
  11. Dec 05, 2012
  12. Dec 04, 2012
    • Francois-Rene Rideau's avatar
      Add a proper input-files method for proto-to-lisp, · aef1afa3
      Francois-Rene Rideau authored
      which shall fix the issue that causes of these actions never being operation-done-p.
      However this does NOT handle recursive import dependencies,
      which requires further work.
      
      Tested: QRes doesn't always recompile the proto and all dependees anymore.
      Reviewer: asedeno
      aef1afa3
  13. Nov 27, 2012
    • Ben Wagner's avatar
      fix cross-package and forward references in cl-protobufs · 8520d6ef
      Ben Wagner authored
      * Previously, if a field in a .proto file referenced a message in
        another proto file using a different lisp package, the cl-protobufs
        library would silently fail to serialize the field.  A similar
        problem would occur if a message defined later in the file used the
        lisp_name option to override the name generated by cl-protobufs.
        This change fixes these issues and others.
      * Add conditions that are signaled when encountering an undefined
        type.
      * Delay assigning lisp classes/types to fields and methods until all
        possible forward references have been parsed.
         * This allows the class slot to be unbound, so check for that case
           in print-object methods.
         * Add a test for forward references to messages that override the
           lisp name.
         * Add a test for references to messages and enums defined in
           another proto file with a different lisp package.
         * Change color-wheel-stability test, because it used "string" as
           the input type for an rpc, which seems to be disallowed (although
           I haven't found this documented anywhere).
      * Signal errors during parsing for undefined types.
         * Add a test for these errors.  Add assert-error macro to qtest.
      * Signal a condition if we are unable to find the definition for a
        field's type during serialization, deserialization, determining an
        object's serialized size, printing text format, parsing text format,
        or generating code for one of the above.
      * Remove logic in find-qualified-name that indirects through lisp
        packages.  Proto packages and lisp packages do not necessarily map
        1-to-1.
      * Always use the schema's lisp package for any symbols generated when
        parsing proto files.
      * When generating lisp code using write-schema-as, set the package to
        the package used in the generated file, so that ~s will print the
        package prefix in the correct circumstances.
      * Remove broken proto1 "streams" parsing ("returns" comes before
        "streams" in every example I've found); replace with proto2 syntax.
      * In process-imports, the call to find-schema using a pathname was not
        giving the expected result.  Sidestep this issue by using the same
        logic to find the schema as is used earlier in the function.
      8520d6ef
  14. Oct 11, 2012
  15. Jun 26, 2012
  16. Jun 14, 2012
  17. Jun 13, 2012
  18. Jun 11, 2012
  19. Jun 05, 2012
  20. Jun 04, 2012
  21. May 30, 2012
  22. May 25, 2012
    • Scott McKay's avatar
      Fix a few more things discovered by the tests: · 67fc7299
      Scott McKay authored
       - 'reinitialize-slot' didn't quite work.
       - Add a geodata example that uses vectors for repeated fields,
         which uncovered a bug in the optimized deserializers.
       - Importing the geodata CLOS classes revealed a bug in default
         handling when the default is provided only in 'defclass'.
       - Fix the knock-on bug in deserialization and the optimized
         (de)serialization caused the above.
       - Add tighter types in 'decode-uint32' and 'decode-uint64'.
      
      Passes 'precheckin'. Even with the new unit tests in place.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@545865 f8382938-511b-0410-9cdd-bb47b084005c
      67fc7299
  23. May 18, 2012
    • Scott McKay's avatar
      Now that Protobufs has a test suite, it found a few things to fix. · 0d1611ab
      Scott McKay authored
       - Don't generate warnings for anonymous enums, they're harmless
         and ubiquitous.
       - 'member' types where are all the members are keywords, is a symbol,
         which got converted to a Protobufs 'string'. Wrong.
       - If a field has an enum type, the (Lisp) default value should be
         treated as a keyword.
       - When parsing a .proto file or using the 'define-xxx' macros, any
         options that are handled specially should be trimmed from the
         options list so that they don't get printed twice.
       - Add 'remove-options' for the above.
       - Make the options printer be more type-aware.
       - Clean up examples.lisp
       - 'schemas-equal' can ignore the schema name/class if they're null.
      
      Passes 'precheckin'. Even with the new unit tests in place.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544737 f8382938-511b-0410-9cdd-bb47b084005c
      0d1611ab
  24. May 16, 2012
    • Scott McKay's avatar
      At Sergey's request, make some of the names better: · a31c828e
      Scott McKay authored
       - 'define-proto' -> 'define-schema'
       - 'protobuf' (class name) -> 'protobuf-schema'
       - 'find-protobuf' -> 'find-schema'
       - 'parse-protobuf-from-file' -> 'parse-schema-from-file'
       - 'parse-protobuf-from-stream' -> 'parse-schema-from-file'
       - 'write-protobuf' -> 'write-schema'
       - 'write-protobuf-as' -> 'write-schema-as'
       - 'ensure-all-protobufs' -> 'ensure-all-protobufs'
       - 'ensure-protobuf' -> 'ensure-protobuf'
       - 'protobuf-upgradable' -> 'schema-upgradable'
       - 'protobufs-equal' -> 'schemas-equal'
       - 'generate-protobuf-schema-for-classes' -> 'generate-schema-for-classes'
       - 'write-protobuf-schema-for-classes' -> 'write-schema-for-classes'
      
      Update the Quake Protobufs schema generator to use the new names.
      
      The Protobufs documentation doesn't say so, but enums can be packed.
       - Update the wire-level protocol to (de)serialize packed enums.
       - Update the serialization code to use the new wire functions.
      
      Passes 'precheckin'.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544299 f8382938-511b-0410-9cdd-bb47b084005c
      a31c828e
    • Scott McKay's avatar
      Tie up a few loose ends with 'unittests.proto'; there are still a few · a13fca91
      Scott McKay authored
      edge case problems, but it's good enough to continue the Stubby work.
      The critical .proto files (descriptor.proto, etc) all appear to work.
      
      More precise mapping of (mainly integer) types from .lisp to .proto files
      so that we can a truly exact model once we compile the .lisp file. It may
      not make any difference, but better safe than sorry.
       - Introduce Lisp type 'int32', 'int64', 'uint32', etc
       - Make Lisp->Protobufs recognize the new Lisp types
       - Make Protobufs schema printers recognize the new types
      
      Fix up the handling of imports and namespaces.
       - Always use truenames to record schemas
       - Fix typo in 'find-enum' that caused it never to search other schemas
       - Record the schema in *all-protobufs* at exactly the right time,
         and simplify 'make-load-form' methods
      
      A few tweaks to (de)serialization.
       - Make the bodies for empty messages not generate compiler warnings
       - Don't make ':packed t' be the default, the user has to say so
       - The user documentation doesn't say so, but booleans can be packed.
      
      Passes 'precheckin'.
      
      
      git-svn-id: http://svn.internal.itasoftware.com/svn/ita/trunk/qres/lisp/quux/protobufs@544222 f8382938-511b-0410-9cdd-bb47b084005c
      a13fca91