Group the commands in ( parentheses ) including the optional chdir.
Update the test-run-program.script.

Changes in launch-program command normalization make
some of the complexity in %normalize-system-command redundant.

Deprecation goes through the following phases:
style-warning, warning, cerror, functionality removed.
Automatically upgrade the deprecation phase at every minor version change
(not every release).

Include minimal testing of the deprecation functionality.
Add deprecation TODO items.

Deprecation will start with 3.2.

Previous error string implied that UIOP *never* supported string
commands on Windows, but actually we do support them on some lisp
implementations.

Always go through CMD in that case, including on Allegro and CLISP, since
the previous behavior is simultaneously non-portable, error-prone and limited;
better to provide a portable well-defined abstraction.
Users who want more can use the (bad) implementation-specific interfaces,
or IOlib.

Simplify the call to RUN-PROGRAM.
Add a PARAMETER-ERROR to %NORMALIZE-COMMAND on unsupported platforms.

With ECL it causes problems. On other platforms it should not be
necessary.

This gets run-program with ECL on windows far closer to working again

This requires a patch to sb-impl::prepare-args relative to sbcl 1.3.10.

The command returned by %redirected-system-command changes the current
directory on its own.

ext:run-shell-command is deprecated but sys:run-program was not fully
functional prior to version 1.4.0

ext:system is a wrapper around ext:run-program that forces :output
nil, which is not something we want.
See also https://bugs.launchpad.net/asdf/+bug/1638870

The check

  (lexicographic<= '< ver '(16 0 0))

Is equivalent to <=16.0.0. The argument '< gives the direction,
and should not be '<= here.

launch-program no longer accepts a parameter :wait; since
the call is surrounded by (wait-process ...), it would be
superfluous anyway.

Elias Pipping authored Nov 06, 2016 and Robert Goldman committed Nov 14, 2016

Prior to this change, run-program's (but not launch-program's)
:error-output and :input would default to :interactive if :output was
interactive. See also https://bugs.launchpad.net/asdf/+bug/1638870

Mistakenly removed the else branch from (EQL :OUTPUT) case in
%NORMALIZE-IO-SPECIFIER.

Elias Pipping authored Nov 06, 2016 and Robert Goldman committed Nov 14, 2016

Prior to this change, :output :interactive was identical to :output
nil. See also https://bugs.launchpad.net/asdf/+bug/1638870

Prior to this change, :output :interactive was identical to :output
nil. See also https://bugs.launchpad.net/asdf/+bug/1638870

No changes to code, just some notes for the reader.

Add a test, too.

Add a test, too.

Add a test, too.

This avoids a forward reference on sbcl/windows.

Also add a comment on a use of symbol-call on ECL.

DIRECTORY is important. It was never actually ignored, except on Allegro,
on which the implementation itself handles the option. Make that explicit.

The other arguments are always passed... though it's unclear whether they
are heeded in all implementations, since we have :allow-other-keys t.
That deserves investigation and a comment update, at some point.

Also, tweak some comments.

Use explicit error checking instead.

Thanks to Elias Pipping for his help getting this commit right.

Make %run-program the alias of launch-program rather than the other way around.
Rename %use-run-program to %use-launch-program. Update tests.

NB: I wanted to move %run-program to backward-driver, but that won't help:
since the function was never exported from uiop/run-program, it wasn't in uiop.

Thanks to Elias Pipping for his help getting this commit right.