6 months agoone more test for an error seen in the wild. not sure whether it's a legal or an illegal cookie string, though.
attila.lendvai@gmail.com [Wed, 15 Jan 2014 22:08:07]
one more test for an error seen in the wild. not sure whether it's a legal or an illegal cookie string, though.

Ignore-this: 46b975f11b8dba17a8723cd45f63031e

9 months agodeleted cookie-case (used only once and is also inflexible), then add error when parsing cookies with illegal domain values.
attila.lendvai@gmail.com [Thu, 24 Oct 2013 23:22:50]
deleted cookie-case (used only once and is also inflexible), then add error when parsing cookies with illegal domain values.

Ignore-this: 4149588f0075d59fdfc5ad990fc8264b

9 months agoadded (currently failing) test that checks for valid domain values while parsing
attila.lendvai@gmail.com [Thu, 24 Oct 2013 23:13:29]
added (currently failing) test that checks for valid domain values while parsing

Ignore-this: 9a3ee3d2f861b6f84849d893e5a9c3ac

2 years agoerr, DON'T turn on corrects-path-p, as it breaks even recent browsers like Chrome v14.
attila.lendvai@gmail.com [Tue, 13 Dec 2011 04:29:29]
err, DON'T turn on corrects-path-p, as it breaks even recent browsers like Chrome v14.

Ignore-this: 74f0e17dd68e6616ee2a3729c7c54f1d

all hail the mutliply obsoleted standards and all their confusion...

2 years agonote that rfc2109 is double obsolete...
attila.lendvai@gmail.com [Tue, 13 Dec 2011 03:53:15]
note that rfc2109 is double obsolete...

Ignore-this: 7b507662dab921e26d3542b51340050f

2 years agohousekeeping
attila.lendvai@gmail.com [Thu, 08 Dec 2011 01:04:24]
housekeeping

Ignore-this: 10d85fecd0647346d661ded576d9596f

2 years agoturn on corrects-path-p by default (although, it should be just deleted)
attila.lendvai@gmail.com [Thu, 08 Dec 2011 01:03:55]
turn on corrects-path-p by default (although, it should be just deleted)

Ignore-this: 6bc14cc837aa349d11f7143d52665ba6

2 years agofix bug that resulted in illegal cookie string with emtpy path elements
attila.lendvai@gmail.com [Thu, 08 Dec 2011 01:02:13]
fix bug that resulted in illegal cookie string with emtpy path elements

Ignore-this: 5b42a8fc77024ea51a21225e3f43e44e

3 years agoadded note that RFC 2109 has been obsoleted by RFC 2965
attila.lendvai@gmail.com [Sun, 19 Sep 2010 08:49:07]
added note that RFC 2109 has been obsoleted by RFC 2965

Ignore-this: 9d51bf11e1e16bf56f035c15ea693534

3 years agoM-x whitespace-cleanup
attila.lendvai@gmail.com [Sun, 19 Sep 2010 08:41:18]
M-x whitespace-cleanup

Ignore-this: fe66308ad9f6a879b7e96858be96f282

3 years agotest for cookie with = sign in its value
attila.lendvai@gmail.com [Sun, 19 Sep 2010 08:39:21]
test for cookie with = sign in its value

Ignore-this: c6bc94a5a563921d4ce7b3dc49d38649

3 years agoadded cleave-sequence and fix parsing cookies with = sign in their values
attila.lendvai@gmail.com [Sun, 19 Sep 2010 08:38:43]
added cleave-sequence and fix parsing cookies with = sign in their values

Ignore-this: ff4d98b8e5105b0768166ef7f16fbbf9

4 years agofix parse-cookies-vnetscape with some random client
attila.lendvai@gmail.com [Mon, 21 Dec 2009 12:45:40]
fix parse-cookies-vnetscape with some random client

Ignore-this: e186d80c9ad5a7e8a5f497dbec2fd61c

4 years agobah, just use parse-integer instead of read-from-string... how about security?
attila.lendvai@gmail.com [Mon, 21 Dec 2009 12:45:16]
bah, just use parse-integer instead of read-from-string... how about security?

Ignore-this: ec35a48384c3cc071fddf2283fdcff35

5 years agomax-age is not a string, drop the quotes around it in print-cookie
attila.lendvai@gmail.com [Wed, 21 Jan 2009 08:59:42]
max-age is not a string, drop the quotes around it in print-cookie

Ignore-this: df8bb7cc8dd454153842b14078d98df7

5 years agofix: max-age may be zero
attila.lendvai@gmail.com [Tue, 16 Sep 2008 15:35:19]
fix: max-age may be zero

7 years agoTurn off corrects-path-p by default
attila.lendvai@gmail.com [Mon, 04 Sep 2006 02:51:56]
Turn off corrects-path-p by default


So, the situation is this: all the examples in the RFC use quotes around the path part,
but the syntax description itself does not contain the quotes and IE gets confused by the
extra (?) quotes, while FF works right with and without them.

I think the entire corrects-path-p should be removed and the tests updated.

7 years agoCall (length "$Version=") at read-time
attila.lendvai@gmail.com [Thu, 31 Aug 2006 17:18:48]
Call (length "$Version=") at read-time

7 years agoKeep the order of cookies as they come
attila.lendvai@gmail.com [Thu, 31 Aug 2006 17:15:40]
Keep the order of cookies as they come


This is important because if you have two cookies with the same name
but with different paths then the more specific ones (based on the path)
must be sooner in the list.

7 years agoTAG rfc2109-version-0.4
Alan Shields [Wed, 09 Aug 2006 13:15:37]
TAG rfc2109-version-0.4

7 years agoupdate the changelog
Alan Shields [Wed, 09 Aug 2006 13:15:15]
update the changelog

7 years agorfc2109-version-0.4
Alan Shields [Wed, 09 Aug 2006 13:14:41]
rfc2109-version-0.4

7 years agoadd a test for the cookie-to-short bug
Alan Shields [Wed, 09 Aug 2006 13:12:24]
add a test for the cookie-to-short bug

7 years agoprevent error for short cookie strings
marijnh@gmail.com [Tue, 01 Aug 2006 03:29:05]
prevent error for short cookie strings

7 years agoeasily strip RFC from rfc2109 for copyright concerns
Alan Shields [Wed, 09 Aug 2006 12:58:18]
easily strip RFC from rfc2109 for copyright concerns

8 years agoCreated a rfc2109.test system
attila.lendvai@gmail.com [Tue, 27 Jun 2006 06:54:46]
Created a rfc2109.test system


Splitting the file into a main/test would have been a bad idea due to the smart
inlining with the standard's text.

The previous solution to always load the file is also bad for performance.

The hopefully final solution is to create an rfc2109.test system and before loading
rfc2109.lisp in it rebind *features* and push a symbol (:test) into it. The main
lisp file #+test for this symbol and defines the tests when it's loaded through
rfc2109.test.

8 years agoDisable fasl compilation in the asdf file
attila.lendvai@gmail.com [Mon, 26 Jun 2006 15:29:23]
Disable fasl compilation in the asdf file


This way we can get rid of the errors arising when rfc2109 is compiled
with 5am loaded and later loaded from fasl without 5am loaded.

8 years agoUNDO: Added missing fiveam dependency
attila.lendvai@gmail.com [Sat, 06 May 2006 17:43:17]
UNDO: Added missing fiveam dependency

8 years agoFIX: empty strings are valid cookie values (they were quoted before)
attila.lendvai@gmail.com [Sat, 06 May 2006 17:45:23]
FIX: empty strings are valid cookie values (they were quoted before)

8 years agoAdded missing fiveam dependency
attila.lendvai@gmail.com [Sat, 06 May 2006 17:43:17]
Added missing fiveam dependency

8 years agoModernise rfc2109 defpackage form.
rich at holygoat dot co uk [Tue, 31 Jan 2006 23:07:51]
Modernise rfc2109 defpackage form.

8 years agorfc2109: allow non-conformant paths, thanks to Richard Newman
Alan Shields [Fri, 27 Jan 2006 13:42:39]
rfc2109: allow non-conformant paths, thanks to Richard Newman

Finally allow non-conformant paths. If the corrects-path-p option
to cookie-string is nil, the library will not coerce the path to
correctness.

8 years agorfc2109: properly handle empty cookie strings (return nil)
Alan-Shields@omrf.ouhsc.edu [Fri, 16 Dec 2005 14:07:46]
rfc2109: properly handle empty cookie strings (return nil)

8 years agoTAG rfc2109-version-0.3.2
Alan-Shields@omrf.ouhsc.edu [Wed, 21 Sep 2005 12:35:37]
TAG rfc2109-version-0.3.2

8 years agorfc2109: allow nil to be passed to safe-parse-cookies
Alan-Shields@omrf.ouhsc.edu [Tue, 20 Sep 2005 14:22:50]
rfc2109: allow nil to be passed to safe-parse-cookies

The docs say that you can pass nil to safe-parse-cookies to have no
legal domains to allow cookies to come from (ie they must come from your
server or not at all).
Whoops.

8 years agoTAG rfc2109-version-0.3.1
Alan-Shields@omrf.ouhsc.edu [Thu, 25 Aug 2005 13:26:18]
TAG rfc2109-version-0.3.1

8 years agorfc2109 - Marco applied the 5am patch, changed keyword
Alan-Shields@omrf.ouhsc.edu [Thu, 25 Aug 2005 13:06:51]
rfc2109 - Marco applied the 5am patch, changed keyword

Marco wanted the feature keyword to be 5am. Less typing for me!

8 years agoEnsure that input to destructuring-bind in parse-cookies-vnetscape is a 2-element list.
rich@holygoat.co.uk [Thu, 25 Aug 2005 09:59:56]
Ensure that input to destructuring-bind in parse-cookies-vnetscape is a 2-element list.

8 years agorfc2109: Add basic testing and a tester
Alan-Shields@omrf.ouhsc.edu [Thu, 11 Aug 2005 15:18:15]
rfc2109: Add basic testing and a tester

Decided to add a basic testing framework - mostly because I'm mucking about
with parsing and another library, want something to let me know when I've
REALLY screwed up.

Please note that the current stable version of FiveAM will not run these tests,
as it doesn't have the *features* that are needed to define them. I've submitted
a patch to Marco, we'll see if he adds it.

8 years agoTAG rfc2109-version-0.3
Alan-Shields@omrf.ouhsc.edu [Wed, 10 Aug 2005 15:31:25]
TAG rfc2109-version-0.3

8 years agorfc2109: update changelog for release
Alan-Shields@omrf.ouhsc.edu [Wed, 10 Aug 2005 15:31:01]
rfc2109: update changelog for release

8 years agorfc2109: update version number for release
Alan-Shields@omrf.ouhsc.edu [Wed, 10 Aug 2005 15:27:25]
rfc2109: update version number for release

Don't really know how I missed updating the version number for 0.2 and 0.2.1...

8 years agorfc2109: add a note about Moz and IE's lack of RFC compliance
Alan-Shields@omrf.ouhsc.edu [Wed, 10 Aug 2005 15:20:04]
rfc2109: add a note about Moz and IE's lack of RFC compliance

Mozilla, Links, and IE all have a problem with quoted PATHs. As quoted paths
are demanded by the RFC, there's really no way around this. Luckily, Moz
has this fixed in latest alpha. Note added to docs as well as workaround suggestion.

Bug reference:
https://bugzilla.mozilla.org/show_bug.cgi?id=277033

There is the option of adding a bonus-points-compatible-cookie-string option for
outputing compatible code, but I would really rather not go down that road.
Output strict, accept loose.

8 years agorfc2109: Update safe-parse-cookies using new understanding of domain cookies
Alan-Shields@omrf.ouhsc.edu [Wed, 10 Aug 2005 15:18:08]
rfc2109: Update safe-parse-cookies using new understanding of domain cookies

After sorting out what the issue was with explicit domains, update safe-parse-cookies
(mostly documentation) to reflect this knowledge.

8 years agorfc2109: redefine valid domain based on a re-reading of 4.3.2
Alan-Shields@omrf.ouhsc.edu [Wed, 10 Aug 2005 13:09:05]
rfc2109: redefine valid domain based on a re-reading of 4.3.2

w3m and the Mozilla bugs set me straight on the reading of 4.3.2.
This patch requires an explicitly defined domain for domain, meaning
it must be:
a value
start with a "."
and contain an embedded "."

8 years agoTAG version-0.2.1
Alan-Shields@omrf.ouhsc.edu [Thu, 04 Aug 2005 14:59:56]
TAG version-0.2.1

8 years agoAdd a changelog - I'll update it each release
Alan-Shields@omrf.ouhsc.edu [Thu, 04 Aug 2005 14:58:42]
Add a changelog - I'll update it each release

8 years agoTAG version-0.2
Alan-Shields@omrf.ouhsc.edu [Thu, 04 Aug 2005 14:57:26]
TAG version-0.2

8 years agoImplement domain-match-p
Alan-Shields@omrf.ouhsc.edu [Thu, 04 Aug 2005 14:55:58]
Implement domain-match-p

While debugging an issue with w3m and cookies (which hasn't gone away, btw),
I needed to check my knowledge of a "domain-match" - I've included the function
in case others find it useful.

8 years agoparse-cookie-string needs to allow quoted strings inside it
Alan-Shields@omrf.ouhsc.edu [Thu, 04 Aug 2005 14:53:36]
parse-cookie-string needs to allow quoted strings inside it

Wrote a small tokenizer that splits - taking into account quoted strings.
We're really getting to the point that a pattern language would be useful.

Anyways, it works well, now.

Next ->