fix: + is an illegal name in postgres names, turn it into _
Thu Jul 23 08:44:35 PDT 2009 attila.lendvai@gmail.com
* fix: + is an illegal name in postgres names, turn it into _
Warning: CRC errors found. These are probably harmless but should be repaired.
See 'darcs gzcrcs --help' for more information.
diff -rN -u old-cl-rdbms/database.lisp new-cl-rdbms/database.lisp
--- old-cl-rdbms/database.lisp 2014-07-29 05:50:38.000000000 -0700
+++ new-cl-rdbms/database.lisp 2014-07-29 05:50:38.000000000 -0700
@@ -89,7 +89,7 @@
"Cuts off the end of names that are too long and appends the hash of the original name."
(assert (>= limit 8))
(let ((name-as-string (concatenate-string prefix (string-downcase name))))
- (iter (for char :in-sequence "*\\/-~%")
+ (iter (for char :in-sequence "+*\\/-~%")
(nsubstitute #\_ char name-as-string :test #'char=))
(let ((name-as-bytes (string-to-octets name-as-string :encoding :utf-8)))
(when (> (length name-as-bytes)
diff -rN -u old-cl-rdbms/oracle/database.lisp new-cl-rdbms/oracle/database.lisp
--- old-cl-rdbms/oracle/database.lisp 2014-07-29 05:50:38.000000000 -0700
+++ new-cl-rdbms/oracle/database.lisp 2014-07-29 05:50:38.000000000 -0700
@@ -85,5 +85,7 @@
(defconstant +maximum-rdbms-name-length+ 30)
(defmethod calculate-rdbms-name ((db oracle) thing name)
+ ;; TODO this may not be neccessary for oracle, or at least not the same way as for the postgres backend.
+ ;; table names in oracle queries are unconditionally in quotes (iirc, that is)
(calculate-rdbms-name-with-utf-8-length-limit name +maximum-rdbms-name-length+))